Skip to content

Conversation

@joaquim-verges
Copy link
Member

@joaquim-verges joaquim-verges commented Oct 24, 2024

Problem solved

Short description of the bug fixed or feature added


PR-Codex overview

This PR focuses on implementing "Sign in with Wallet" functionality across various locales and updating related authentication options in the thirdweb package.

Detailed summary

  • Added signInWithWallet translations in multiple locales (kr, ja, vi, tl, de, es, fr, en).
  • Updated AuthOption type to include wallet.
  • Modified components to handle wallet linking state.
  • Adjusted authentication options to replace siwe with wallet.
  • Enhanced WalletAuth to manage linking states.
  • Updated ConnectWalletSocialOptions to include wallet login handling.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@vercel
Copy link

vercel bot commented Oct 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 24, 2024 7:51am
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 24, 2024 7:51am
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 24, 2024 7:51am
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 24, 2024 7:51am

@changeset-bot
Copy link

changeset-bot bot commented Oct 24, 2024

🦋 Changeset detected

Latest commit: 69644fe

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
thirdweb Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@graphite-app
Copy link
Contributor

graphite-app bot commented Oct 24, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@joaquim-verges joaquim-verges marked this pull request as ready for review October 24, 2024 02:26
@github-actions github-actions bot added Dashboard Involves changes to the Dashboard. Playground Changes involving the Playground codebase. packages labels Oct 24, 2024
Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @joaquim-verges and the rest of your teammates on Graphite Graphite

@github-actions
Copy link
Contributor

github-actions bot commented Oct 24, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 42.9 KB (0%) 859 ms (0%) 3.9 s (+41.06% 🔺) 4.7 s
thirdweb (cjs) 102.73 KB (0%) 2.1 s (0%) 8.9 s (+31.98% 🔺) 10.9 s
thirdweb (minimal + tree-shaking) 4.84 KB (0%) 97 ms (0%) 127 ms (-25.1% 🔽) 224 ms
thirdweb/chains (tree-shaking) 498 B (0%) 10 ms (0%) 53 ms (-22.12% 🔽) 63 ms
thirdweb/react (minimal + tree-shaking) 17.34 KB (0%) 347 ms (0%) 337 ms (-29.99% 🔽) 684 ms

@codecov
Copy link

codecov bot commented Oct 24, 2024

Codecov Report

Attention: Patch coverage is 5.00000% with 38 lines in your changes missing coverage. Please review.

Project coverage is 45.42%. Comparing base (9fadbcc) to head (69644fe).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...irdweb/src/react/web/wallets/in-app/WalletAuth.tsx 0.00% 19 Missing ⚠️
.../web/wallets/shared/ConnectWalletSocialOptions.tsx 0.00% 13 Missing ⚠️
...ets/ecosystem/get-ecosystem-wallet-auth-options.ts 0.00% 4 Missing ⚠️
...web/wallets/ecosystem/EcosystemWalletConnectUI.tsx 0.00% 1 Missing ⚠️
...wallets/in-app/core/authentication/getLoginPath.ts 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5153      +/-   ##
==========================================
- Coverage   45.45%   45.42%   -0.03%     
==========================================
  Files        1065     1065              
  Lines       55122    55149      +27     
  Branches     3976     3972       -4     
==========================================
  Hits        25053    25053              
- Misses      29377    29404      +27     
  Partials      692      692              
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from 9fadbcc
packages 40.44% <5.00%> (-0.03%) ⬇️

*This pull request uses carry forward flags. Click here to find out more.

Files with missing lines Coverage Δ
packages/thirdweb/src/wallets/types.ts 100.00% <100.00%> (ø)
...web/wallets/ecosystem/EcosystemWalletConnectUI.tsx 9.01% <0.00%> (-0.08%) ⬇️
...wallets/in-app/core/authentication/getLoginPath.ts 7.14% <50.00%> (ø)
...ets/ecosystem/get-ecosystem-wallet-auth-options.ts 4.00% <0.00%> (-0.77%) ⬇️
.../web/wallets/shared/ConnectWalletSocialOptions.tsx 6.93% <0.00%> (-0.22%) ⬇️
...irdweb/src/react/web/wallets/in-app/WalletAuth.tsx 1.44% <0.00%> (-0.11%) ⬇️

... and 2 files with indirect coverage changes

@joaquim-verges joaquim-verges merged commit 47b1bbb into main Oct 24, 2024
30 of 31 checks passed
@joaquim-verges joaquim-verges deleted the feat_enable_sign_in_with_wallet_for_ecosystems branch October 24, 2024 08:06
@jnsdls jnsdls mentioned this pull request Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Dashboard Involves changes to the Dashboard. packages Playground Changes involving the Playground codebase.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants